Issue 72262 - [a11y] Change unit of measure for margins
Summary: [a11y] Change unit of measure for margins
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 2.0.4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: nospam4obr
QA Contact: issues@sw
URL:
Keywords: accessibility
: 72161 (view as issue list)
Depends on:
Blocks:
 
Reported: 2006-12-04 17:45 UTC by richburridge
Modified: 2013-08-07 14:43 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
This patch makes OOo report (left/right/to/bottom) margins in mm (6.01 KB, patch)
2007-07-19 14:33 UTC, nospam4obr
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description richburridge 2006-12-04 17:45:58 UTC
See also Orca bug #376517 which is blocked by this bug:
http://bugzilla.gnome.org/show_bug.cgi?id=376517

Steps to reproduce:
1. Download, configure, build and install Orca v2.17.3 available from
   http://ftp.gnome.org/pub/gnome/sources/orca/2.17/orca-2.17.3.tar.gz
2. Run Orca
3. Launch OOo Writer
4. Press the "Increase Indent" button on Writer's Formatting toolbar
5. Type "This is a test."
6. Move to any character within "This is a test" and press Insert F to
   speak the text attributes.

Actual results:
Orca reports that the text indentation is "0".
Comment 1 malte_timmermann 2007-04-25 19:06:23 UTC
A11y => 2.3

OBR says the value is != 0, but probably nothing useful (pixels), so we must
discuss what to return.

Comment 2 malte_timmermann 2007-04-25 19:07:28 UTC
assign to some developer...
Comment 3 Oliver Specht 2007-06-27 09:58:35 UTC
Reassigned to od
Comment 4 Oliver-Rainer Wittmann 2007-07-04 11:06:08 UTC
as discussed with OBR:
- It's no defect in the Writer accessibility - by "Increase Indent" the "left
margin" is changed, not the "indentation".
- But, there is left a unit "defect", which has to be solved in the ATK bridge

Thus, OBR takes over this issue
Comment 5 nospam4obr 2007-07-10 17:04:26 UTC
OK, will change the unit of measure to 'mm'. As OOo uses 100th of mm internally,
the representation might be a float value with two decimals max.

Do we need a "ruler unit of measure" attribute for Orca as well ?
Comment 6 nospam4obr 2007-07-19 14:33:27 UTC
Created attachment 46916 [details]
This patch makes OOo report (left/right/to/bottom) margins in mm
Comment 7 nospam4obr 2007-07-19 14:34:06 UTC
@pb: can we still add this fix to CWS swa11y01 ?
Comment 8 pb 2007-07-19 20:09:45 UTC
pb: added to swa11y01 (vcl added to cws).
Comment 9 nospam4obr 2007-07-20 12:00:31 UTC
Patch applied to CWS swa11y01.
Comment 10 Oliver-Rainer Wittmann 2007-07-24 13:07:03 UTC
OD->ES: Please verify in internal installation set of cws swa11y01
Comment 11 eric.savary 2007-07-31 14:07:30 UTC
Verified in CWS swa11y01
Comment 12 eric.savary 2007-08-22 10:28:34 UTC
*** Issue 72161 has been marked as a duplicate of this issue. ***
Comment 13 Oliver-Rainer Wittmann 2007-08-22 10:36:17 UTC
.
Comment 14 richburridge 2008-01-07 19:22:20 UTC
This problem seems to have reappeared. Reopening.
Tested with both the OOo 2.3 that comes with Ubuntu Gutsy 
and latest OOo 2.4-dev for Linux.

It's currently blocking Orca bug #502101:
http://bugzilla.gnome.org/show_bug.cgi?id=502101

From that bug, here's how to reproduce the problem:

0/ Get latest Orca from SVN HEAD and apply the patch attached to bug #502101.
   Diffs can be found at:
   http://bugzilla.gnome.org/attachment.cgi?id=102337
   Configure, build and install.

1/ Start "swriter --norestore"

2/ Start latest Orca

3/ Give focus to the swriter window and type Tab

With the patch applied, the following debug is output by Orca:
allAttributes:  {'vertical-align': 'baseline', 'weight': '400', 'family-name':
'Times', 'fg-color': '0,0,0', 'strikethrough': 'none', 'underline': 'none',
'size': '12', 'style': 'normal', 'scale': '1', 'left-margin': '0mm', 'stretch':
'normal', 'pixels-above-lines': '0mm', 'paragraph-style': 'Default',
'text-shadow': 'none', 'direction': 'ltr', 'justification': 'left', 'variant':
'normal', 'font-effect': 'none', 'text-rotation': '0', 'invisible': 'false',
'writing-mode': 'lr-tb', 'indent': '0mm', 'language': 'en-us',
'pixels-below-lines': '0mm', 'bg-color': '255,255,255', 'right-margin': '0mm',
'text-decoration': 'none', 'line-height': '100%'}

Notice 'left-margin': '0mm'

4/ Type Tab again.

Debug output shows:

allAttributes:  {'vertical-align': 'baseline', 'weight': '400', 'family-name':
'Times', 'fg-color': '0,0,0', 'strikethrough': 'none', 'underline': 'none',
'size': '12', 'style': 'normal', 'scale': '1', 'left-margin': '0mm', 'stretch':
'normal', 'pixels-above-lines': '0mm', 'paragraph-style': 'Default',
'text-shadow': 'none', 'direction': 'ltr', 'justification': 'left', 'variant':
'normal', 'font-effect': 'none', 'text-rotation': '0', 'invisible': 'false',
'writing-mode': 'lr-tb', 'indent': '0mm', 'language': 'en-us',
'pixels-below-lines': '0mm', 'bg-color': '255,255,255', 'right-margin': '0mm',
'text-decoration': 'none', 'line-height': '100%'}

We still have:
'left-margin': '0mm'

5/ Type Insert-f (get text attributes).

SPEECH OUTPUT: 'Insert'
SPEECH OUTPUT: 'f'
SPEECH OUTPUT: 'size 12'
SPEECH OUTPUT: 'family-name Times'

No mention of any indentation.


Comment 15 richburridge 2008-02-15 19:10:14 UTC
Eric, any update on this one? Thanks.
Comment 16 eric.savary 2008-03-19 01:27:48 UTC
@OBR: at-poke lists no attribute at caret in this case.
Comment 17 eric.savary 2008-03-19 01:28:21 UTC
Changed target
Comment 18 williewalker 2008-04-14 22:33:51 UTC
For clarification, the user experience we're trying to provide the user is the
level of indentation when they are at when they press the "Tab" key.  I'm not
sure which is the correct attribute to look at (e.g., left margin, indent,
etc.), but Rich's comments from 07-Jan-2008 seem to indicate Orca is not getting
any useful information in this regard.

Can you advise which attribute is the most appropriate for us to look at in this
case?
Comment 19 nospam4obr 2008-04-16 14:58:26 UTC
The tab is a character of the paragraph, not an indention. The scenario
described  previously (pressing "increase indent") still works as expected.

OOo currently does not expose the tab stop positions yet (and atk does not
define how to do so). If Orca does need the tab stop positions, I'll suggest to
file another issue and look for tab stops in the CSS specs. 

Would that work for you ?
Comment 20 nospam4obr 2008-04-21 06:17:03 UTC
I have submitted issue 88513 for adding tab stop support, closing this issue.
Comment 21 nospam4obr 2008-04-21 06:17:23 UTC
.